Add helpers to read/write in same language as spec#8
Open
kaspergrubbe wants to merge 1 commit intomasterfrom
Open
Add helpers to read/write in same language as spec#8kaspergrubbe wants to merge 1 commit intomasterfrom
kaspergrubbe wants to merge 1 commit intomasterfrom
Conversation
Used the vocabulary from https://tools.ietf.org/html/rfc6143 # Conflicts: # ChangeLog
Collaborator
|
Seems fine to me, though the read/write naming seems slightly counter-intuitive as nothing is read/written. Seems all of the callers here and in your later commits are of the form |
Owner
Author
|
@aquasync That's fair, I have some more changes planned, so I will try to think about how I can do this better without breaking the current API. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used the vocabulary from https://tools.ietf.org/html/rfc6143
It makes it very easy to read/write following the RFC6143, and we don't have to think about pack/unpack.
Work in progress.